search

BrianHenryIE / strauss

Prefix PHP namespaces and classnames to allow multiple versions of libraries to exist without conflict.
https://brianhenryie.github.io/strauss/
MIT License
143 stars 23 forks source link

Add Check version job to release workflow #120

Closed szepeviktor closed 1 month ago

szepeviktor commented 1 month ago

@BrianHenryIE It is too late because the release is already published, but ...

BrianHenryIE commented 1 month ago

I really like this but I don't think it solves the issue completely/in the ideal way. What will happen with this is I will create a release and click publish, then this will give the benefit of a "workflow failed" email for me to act on. I wonder could we expand on this to delete the existing release, capture the content, create the change and then create a new release?! (I'm ad-libbing here). Would that have any impact on Packagist? I.e. I think this repo has a webhook that pushes the release to Packagist, would pushing a new release with the same version number be a problem?

Thanks, as always, for your contributions.

szepeviktor commented 1 month ago

The above forth-and-back "solution" is also error prone. Moving a git tag causes caching issues on Packagist. Currently everything begins with the manual creation of a tag+release.

All I can think of is a manual workflow that checks everything and creates a release. image

This is well-known, frequently seen problem!