search

BrianLi009 / PhysicsCheck

Other
5 stars 3 forks source link

Simplification should only add back edge variables #1

Closed curtisbright closed 2 years ago

curtisbright commented 2 years ago

https://github.com/BrianLi009/private_ks/blob/c7c1e0abd5bc3211547e453f18d15ff485742335/simplification/simplify.sh#L59

Hi Brian, we discussed this issue previously -- the simplification script shouldn't add removed non-edge variables back into the instance. This is incorporated into simplify-by-var-removal.sh but the simplify.sh script adds back all variables.

I expect updating this will make the simplification process a bit more effective and therefore it may be optimal to run the simplification for a bit longer. Could you fix this and rerun the simplification timings? Thanks.

BrianLi009 commented 2 years ago

Hi Curtis. Thanks for the comment, this task was indeed missed. I have made changes to simplify.sh, so that non-edge vars will not be added back into the instance.

Will update our simplification excel sheet with this. Thanks again.

BrianLi009 commented 2 years ago

simp job resubmitted :)