search

BrianSidebotham / arm-tutorial-rpi

Raspberry-Pi Bare Metal Programming in C Tutorial
https://www.valvers.com/open-software/raspberry-pi/bare-metal-programming-in-c-part-1/
MIT License
585 stars 177 forks source link

fix typo #15

Closed arcturus140 closed 5 years ago

arcturus140 commented 5 years ago

RPi 2B v1.1 uses BCM 36 while RPi 2B 1.2 uses 37. Might be confusing so I specified the version.

#14 still needs a fix couldn't find source.

BrianSidebotham commented 5 years ago

Hi @arcturus140 - thanks for the PR - it's always good to get things more tidy.

However, I do not want to remove the quotes around ${TC_PATH}${CROSS_COMPILE}gcc because those quotes support spaces in the directory/filename (I know there shouldn't be spaces in that path really, but that's what the quotes are for).

If you can put those back I can merge your PR. Thanks.

arcturus140 commented 5 years ago

got it, tomorrow.

arcturus140 commented 5 years ago

fixed! I also set the quotes, usually. Always good to have them, just in case :smile:

BrianSidebotham commented 5 years ago

Thanks @arcturus140 - sorry progress on this project has been a bit slow lately!