search

BrianSipple / ember-cli-svgstore

Ember addon to combine SVGs as symbols in a spritesheet.
MIT License
20 stars 8 forks source link

Add option to allow source files to be placed in the /public dir #1

Closed slindberg closed 9 years ago

slindberg commented 9 years ago

SVGs that get processed into a spritesheet are more or less static assets, and it makes sense for them to live in the project's public/ dir. However, by existing in that dir, ember-cli automatically includes them in the distribution, effectively duplicating them all. This adds an option to prevent processed SVGs from making it to the final dist build.

dfreeman commented 9 years ago

Thanks for the PR (and for model fragments)! The change seems reasonable, but it it may be worth documenting the details of the flag, since there's some quirky behavior involved.

For example, if I have sources somewhere in app and set excludeSourceFiles to false, I'm still not going to see them in the output anywhere, since Ember CLI is going to filter SVGs out of that tree by default, won't it?

slindberg commented 9 years ago

For example, if I have sources somewhere in app and set excludeSourceFiles to false, I'm still not going to see them in the output anywhere, since Ember CLI is going to filter SVGs out of that tree by default, won't it?

Yep. Definitely a little confusing, I'll add a description in the readme. Sorry that I didn't give the PR a description either... I don't know what was going on in my head when I clicked the create button.

dfreeman commented 9 years ago

Awesome, thanks! Just merged and published 0.2.0 to NPM.

slindberg commented 9 years ago

Awsome, thanks!