search

BrianSipple / ember-cli-svgstore

Ember addon to combine SVGs as symbols in a spritesheet.
MIT License
20 stars 8 forks source link

Missing style attribute #9

Closed tamzinblake closed 7 years ago

tamzinblake commented 8 years ago

Previously, the generated file would have a style="display:none" attribute on the svg element. After a recent reinstall of my dependencies, the generated file no longer has that attribute.

Is this intentional? Is there a way to configure this? I don't actually know if this is an issue for ember-cli-svgstore or broccoli-svgstore or svgstore or some other dependency, but don't know where to look either.

tamzinblake commented 8 years ago

Wondering if https://github.com/svgstore/svgstore/issues/8 is related

dfreeman commented 8 years ago

This addon is really just a thin layer of plumbing between the ember-cli build and broccoli-svgstore, which is where most of the real action is — it probably makes sense to file there, but I suspect you're right that it's related to svgstore/svgstore#8 (which, incidentally, was filed by @briansipple, the maintainer of broccoli-svgstore).

tamzinblake commented 8 years ago

I opened an issue on broccoli-svgstore; hopefully, they'll be able to point me in the right direction.

Given svgstore/svgstore#8 I suspect ember-cli-svgstore might end up needing to implement some sort of configuration passthrough that will allow passing options to svgstore (unless that exists already?)

dfreeman commented 8 years ago

No such passthrough currently exists, but I'll keep an eye on svgstore/broccoli-svgstore#17 and make whatever changes are necessary here once we know what they are.

tamzinblake commented 7 years ago

Looks like this might be fixed by svgstore/broccoli-svgstore#24

dfreeman commented 7 years ago

Yep, I got a ping on that PR earlier this morning. I'll hopefully have a chance to cut a new release sometime in the next couple days, but if you (or any one else interested) wanted to open a PR bumping the broccoli-svgstore dependency and changing any tests/documentation that need it, that would definitely help speed things along 🙂