Open MatthewSteen opened 2 years ago
Ok, we can make this change. I think it makes sense to model the relationship as Panel hasPart Module
.
What do you feel is more appropriate for types? Right now Array
is a collection of Panel
, so Array
is not an equipment in its own right. Should Panel
also be a collection (of Module
), or should it remain an equipment? The hasPart
relationship is appropriate in either situation
I think Panel
could remain an equipment if Collection is intended to be a top-level type. Otherwise, I'm not sure where to make the distinction since Module
is a "collection" of cells. I wasn't aware that Panel actually had a technical meaning and am not sure how frequently they're used in design/practice. For example, NREL's SAM tool does not have the concept of panels.
What if we treat Panel and Module as equivalent? Our "Panel" definition currently refers to the definition of a PV Module
I think that could work. Module is technically correct (used by NREL's SAM and EnergyPlus), but Panel is the colloquial term. I haven't found the definition of panel above anywhere else than the FSEC link, so it's probably not very common.
For reference...
SolarPanel
as a type of IfcSolarDevice
Photovoltaic Panel
So, feel free to keep it as is.
Researching this a bit more, the original definitions above seem to be correct per the standards organizations. So recommend PhotovoltaicModule
.
solar panel—discouraged in favor of the more precise terms collector, flat-plate or module, photovoltaic. See also panel, photovoltaic.
Module (flat-plate) – The smallest environmentally protected assembly of solar cells and ancillary parts. Such as interconnects and terminals, intended to generate DC power under nonconcentrated sunlight. Panel (flat-plate) – A collection of modules mechanically fastened together, wired, and designed to provide a field-installable unit.
I believe the current usage of
PV_Panel
is incorrect according to its definition, which I think is intended to mean aPV_Module
, "Panel" is probably the colloquially term, but actually means a collection of modules.https://energyresearch.ucf.edu/consumer/solar-technologies/solar-electricity-basics/cells-modules-panels-and-arrays/