search

BrickSchema / Brick

Uniform metadata schema for buildings
http://brickschema.org/
BSD 3-Clause "New" or "Revised" License
289 stars 78 forks source link

Expand pressure sensor and setpoint #607

Closed connorjcantrell closed 8 months ago

connorjcantrell commented 9 months ago

Proposing to expand upon pressure sensor and setpoint classes, including static air pressure, differential pressure, and water pressure. Based on https://github.com/BrickSchema/Brick/issues/551 issue.

connorjcantrell commented 9 months ago

@gtfierro Please see https://github.com/BrickSchema/Brick/pull/603 as a possible solution for the failed build https://github.com/BrickSchema/Brick/actions/runs/7293521910/job/19876738252?pr=607.

connorjcantrell commented 8 months ago

Hi @gtfierro,

Is there a way to see the obsolete terms file from the output of the build process? It would be helpful to see the which terms are causing the assertion. I also created a PR for outputting the terms in the error message: https://github.com/BrickSchema/Brick/pull/609

gtfierro commented 8 months ago

I merged your PR. Thanks for making the change! I usually don't run into this problem because I just run tests locally

--

Dr. Gabe Fierro | https://home.gtf.fyihttps://home.gtf.fyi/

Assistant Professor of Computer Science | Colorado School of Mines

Joint Appointment | National Renewable Energy Laboratory

From: Connor Cantrell @.> Sent: Friday, January 12, 2024 9:41:24 AM To: BrickSchema/Brick @.> Cc: Gabe Fierro @.>; Mention @.> Subject: [EXTERNAL] Re: [BrickSchema/Brick] Expand pressure sensor and setpoint (PR #607)

CAUTION: This email originated from outside of the Colorado School of Mines organization. Do not click on links or open attachments unless you recognize the sender and know the content is safe.

Hi @gtfierrohttps://github.com/gtfierro,

Is there a way to see the obsolete terms file from the output of the build process? It would be helpful to see the which terms are causing the assertion. I also created a PR for outputting the terms in the error message: #609https://github.com/BrickSchema/Brick/pull/609

— Reply to this email directly, view it on GitHubhttps://github.com/BrickSchema/Brick/pull/607#issuecomment-1889623823, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAANRCXRVLQ2EHP53LMU3OLYOFRTJAVCNFSM6AAAAABA67TZAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBZGYZDGOBSGM. You are receiving this because you were mentioned.Message ID: @.***>