gtfierro
commented
10 months ago The prefix still needs to be fixed in your PR. Either property is fine
--
Dr. Gabe Fierro | https://home.gtf.fyihttps://home.gtf.fyi/
Assistant Professor of Computer Science | Colorado School of Mines
Joint Appointment | National Renewable Energy Laboratory
From: Xiaohan Fu @.> Sent: Sunday, August 20, 2023 4:24:46 PM To: BrickSchema/docs @.> Cc: Gabe Fierro @.>; Comment @.> Subject: [EXTERNAL] Re: [BrickSchema/docs] fix a typo in external-representations.md (PR #17)
CAUTION: This email originated from outside of the Colorado School of Mines organization. Do not click on links or open attachments unless you recognize the sender and know the content is safe.
Either way works if I'm understanding correctly. ref:hasTimeseriesReference should be a subProperty of ref:hasExternalReference Best regards, Xiaohan Fu
On Sun, Aug 20, 2023 at 2:55 PM Gabe Fierro @.***> wrote:
@.**** requested changes on this pull request.
I think it should actually be ref:hasExternalReference, no?
— Reply to this email directly, view it on GitHub https://github.com/BrickSchema/docs/pull/17#pullrequestreview-1585966048, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADVJW23A5OTDYVSF23JUWH3XWKBT5ANCNFSM6AAAAAA3XQ3P4Y . You are receiving this because you authored the thread.Message ID: @.***>
— Reply to this email directly, view it on GitHubhttps://github.com/BrickSchema/docs/pull/17#issuecomment-1685411847, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAANRCSFFAR4CZOQUPTI3VDXWKFC5ANCNFSM6AAAAAA3XQ3P4Y. You are receiving this because you commented.Message ID: @.***>
Reapor-Yurnero
Either way works if I'm understanding correctly. ref:hasTimeseriesReference should be a subProperty of ref:hasExternalReference Best regards, Xiaohan Fu
On Sun, Aug 20, 2023 at 2:55 PM Gabe Fierro @.***> wrote: