Brickimedia / brickimedia

Brickimedia Source Code
http://www.brickimedia.org
13 stars 4 forks source link

VisualEditor enabled for most skins #32

Closed georgebarnick closed 10 years ago

georgebarnick commented 11 years ago

It'd be nice to have VisualEditor installed and enabled on some of our skins, especially Refreshed.

RugheCotone commented 11 years ago

My first thought was no, I hate visual editors. But that actually looks really promising.

Drewlzoo commented 11 years ago

Definitely, especially now that Wikia is adding it. I think we'd be okay with out it, but it's definitely very helpful for newer editors. On Oct 15, 2013 1:01 AM, "George Barnick" notifications@github.com wrote:

It'd be nice to have VisualEditorhttp://www.mediawiki.org/wiki/Extension:VisualEditorinstalled and enabled on some of our skins, especially Refreshed.

— Reply to this email directly or view it on GitHubhttps://github.com/Brickimedia/brickimedia/issues/32 .

adamrobcarter commented 11 years ago

Sounds good. We can always set a prefs option if any experienced users hate it, but I don't see why many would, it still lets you edit code.

georgebarnick commented 11 years ago

All Wikimedia projects had it recently. It had mixed reactions, but since its a user preference, you can disable it if you want.

adamrobcarter commented 11 years ago

Ok, as with other extensions, the version of VisualEditor for MW 1.20 is a long way behind the current work, so I think we should wait until we've upgraded to 1.22

georgebarnick commented 11 years ago

Should we just upgrade now?

adamrobcarter commented 11 years ago

1.22 isn't fully released till november, so we'll wait till then. I'm working on ways to make the upgrade as swift as possible though

SirComputer1 commented 10 years ago

We've upgraded now. Any updates? @UltrasonicNXT @georgebarnick

adamrobcarter commented 10 years ago

Well, having it on vector would be easy right now, and deep sea require the minimum of work.However, I doubt it would work on refreshed. We could try - it was opened up to other skins here. Apparently there are plans to allow skins to subclass VisualEditor for themselves, but I can't find any more docs on that so it must not be done yet. IMO, we should wait a bit for it to become more stable, and allow this subclassing before trying it on refreshed. I've found somewhere saying that people should be able to customize it for other skins, but that's litterally it, there is no other detail given.

georgebarnick commented 10 years ago

VisualEditor works on Oasis on Wikia. There's no reason why we couldn't make it work on Refreshed.

adamrobcarter commented 10 years ago

But Wikia partially built VisualEditor and I didn't :P

I will have a look, but it's can't be that high on my priorities list for the mo.

georgebarnick commented 10 years ago

I've set up VisualEditor on dev. It's working in the Vector skin and pretty much completely in DeepSea. All it needs to actually function is for Parsoid to be configured.

georgebarnick commented 10 years ago

In a little while I'll set VisualEditor up on Vector and DeepSea. It won't function yet since Parsoid isn't running at the moment due to server issues. Refreshed's VisualEditor support will come as a part of #274.