search

Brickimedia / brickimedia

Brickimedia Source Code
http://www.brickimedia.org
13 stars 4 forks source link

Refreshed dropdown menus don't work #428

Closed adamrobcarter closed 8 years ago

adamrobcarter commented 8 years ago

Since update to 1.26.

Sometimes they do work when editing pages

adamrobcarter commented 8 years ago

https://github.com/Brickimedia/Refreshed/blob/master/refreshed/refreshed.js#L174 is the offending line

georgebarnick commented 8 years ago

@UltrasonicNXT don't believe that was the issue

chriscook18 commented 8 years ago

It seems to be namespace dependent? Search, dropdowns and notifications work fine on Special pages and Brickipedia namespace, but not on user talk pages

Edit: Okay, now its stopped on those two spaces again too

georgebarnick commented 8 years ago

@MtMNC are you able to help debug?

adamrobcarter commented 8 years ago

I think it's because the refreshed scripts (among others) seem to be loaded before jquery

adamrobcarter commented 8 years ago

https://github.com/Brickimedia/Refreshed/blob/master/Refreshed.skin.php#L27

adamrobcarter commented 8 years ago

Okay well the reason nothing is happening is because https://github.com/Brickimedia/Refreshed/blob/master/refreshed/refreshed.js#L124 isn't being triggered

adamrobcarter commented 8 years ago

JS needs rewrite though

georgebarnick commented 8 years ago

The Refreshed toolbar dropdown doesn't work though ("more" / "tools" button in the edit, history, etc tools bar)

MtMNC commented 8 years ago

Afraid I can't right now, my computer's in for repairs... I should get it back this weekend though.

On Jan 8, 2016, at 10:39 AM, George Barnick notifications@github.com wrote:

@MtMNC are you able to help debug?

— Reply to this email directly or view it on GitHub.

georgebarnick commented 8 years ago

No worries. We're working to resolve any lingering bugs. Once you get back you can take a look at some of the code for Refreshed and maybe help clean it up and make it more efficient. :)