Objects on brickimedia header don't respond to tap on mobile

Brickimedia / brickimedia

Brickimedia Source Code

http://www.brickimedia.org

13 stars 4 forks source link

Objects on brickimedia header don't respond to tap on mobile #431

Closed neoncitylights closed 8 years ago

neoncitylights commented 8 years ago

Whenever I tap on anything on the header such as:

The hamburger icon which should pull up a sidebar
The user avatar, which should pull up a user dropdown menu
Magnifying glass icon, which should pull up a search box.

Nothing happens - a single tap doesn't do anything and a double tap just zooms the screen into that tapped area.

georgebarnick commented 8 years ago

Header scripts have been and still need rewriting for the most part.

@UltrasonicNXT @MtMNC

chriscook18 commented 8 years ago

Doesn't seem to be an issue on Chrome on an S3. (Although there is a separate issue where the search box and notifications start off screen - I'll screenshot them at some point).

georgebarnick commented 8 years ago

@codynguyen1116 Also please try logging in to make sure you aren't being served an out of date cache of the skin.

(Working for me on Chrome on Nexus 5X as well though)

neoncitylights commented 8 years ago

Ah okay I logged in and working, it's just part of #425 but if the code for the headers still need rewriting, I'll keep this open. Although when I logged in, there are problems with echo on mobile which I'll put into a new issue.

neoncitylights commented 8 years ago

Tested the site while logged out on Safari, Chrome, and Firefox for iOS on my iPhone 5S and everything worked fine. I'm assuming the bug is gone now but if people are still having issues, feel free to reopen this