search

Brickimedia / brickimedia

Brickimedia Source Code
http://www.brickimedia.org
13 stars 4 forks source link

Preferences tabs aren't displaying correctly in Refreshed #473

Closed neoncitylights closed 8 years ago

neoncitylights commented 8 years ago

Preferences tabs aren't displaying on Refreshed skin, but are in other skins such as Vector, and DeepSea.

image image image

chriscook18 commented 8 years ago

Can confirm that this has happened for at the very least the last few months, if not further back - I can't recall a time when it wasn't doing that in. On 27 Mar 2016 17:50, "Cody Nguyen" notifications@github.com wrote:

Preferences tabs aren't displaying on Refreshed skin, but are in other skins such as Vector, and DeepSea.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub

mary-kate commented 8 years ago

First the historical stuff, because I like history and sometimes it's useful to know it, too! Nowadays there's a ResourceLoader module called mediawiki.special.preferences, which, as the name might suggest, is loaded on Special:Preferences. For whatever reason, this module still contains only some very basic styles, so just like years ago, all skins need to implement (read: copy-paste from MonoBook) the "default" styling of #preftoc themselves. Refreshed didn't, so the tabs weren't rendering the way we're used to. Now (Brickimedia/Refreshed@cbdb1d6) they do, so all that's left here is to deploy the fix.

MacFan4000 commented 8 years ago

Its like that for me too.

neoncitylights commented 8 years ago

@georgebarnick Can you push this commit to the server also? Thanks :)

neoncitylights commented 8 years ago

Superseded by https://phabricator.wikimedia.org/T143512 (update Refreshed extension)