issues
search
Bridgeconn
/
usfm-grammar
An elegant USFM parser.
https://usfmgrammar.vachanengine.org/
MIT License
36
stars
14
forks
source link
Fix issue of missing components in output
#198
Closed
kavitharaju
closed
1 year ago
kavitharaju
commented
1 year ago
This PR includes
More tests and fixes in the context of #192 All markers in the input USFM are found using regex pattern and the outputs
SyntaxTree,
dict and
USX are searched for these markers to ensure all usfm components are represented in parsed output formats
A grammar change to combine adjacent poetry elements within one "poetry" element in syntax tree and there by in JSON
Changes in to_list()
To accommodate for the change in dict for using
v
and
c
as keys instead of chapterNumber and verseNumber
Tests to make sure conversions happen without failure
Minor fixes to handle some failures
This methods needs to be re-written to work with the flat JSON schema. So, no further changes or tests done for now.
A small change in Exception handling that was part of previous PR
Four tests that use \k-s as milestone have been excludeda and noted, as I have doubt about the correctness of this usage.
This PR includes
v
andc
as keys instead of chapterNumber and verseNumber