Closed kavitharaju closed 10 months ago
The changes look good. Are you planing to add the change to Book Code regex separately (basically to mirror what's followed in USX)?
Honestly I had forgotten that change. But now I remember what we had decided was
About point 2, is that okay? Or should we do it just like in usx by listing all codes as enum and then opening it up for any 3 letter string? I see the following reasons to not to
Agreed. I will merge this in and we can work on the 'regex for book code' change as a separate PR. Also, let's leave out the special schema handling for now- enforcing any three letter regex is probably good enough (probably using what USX specifies already).
Closes #225 Implementing the changes suggested in USJ schema by the USFM/X Committee
{type: "val1:val2"}
keep two fields{type:"val1", marker: "val2"}
Changes in this PR