search

BridgesUNCC / bridges-cxx

C++ client library for Bridges
http://bridgesuncc.github.io
2 stars 5 forks source link

C++ client should support elevation interface #104

Closed esaule closed 4 years ago

esaule commented 4 years ago

probably copy implementation from python

esaule commented 4 years ago

kr, jay, one of you want to look at this?

krs-world commented 4 years ago

Yes, fine..     assign to me..

    -- krs

On 2/26/20 10:02 PM, Erik Saule wrote:

kr, jay, one of you want to look at this?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/BridgesUNCC/bridges-cxx/issues/104?email_source=notifications&email_token=ABLFEOB556OMSPKVZCBCM7TRE4UMVA5CNFSM4K4SOVK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENCXMXA#issuecomment-591754844, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLFEOBVAS5CCSHWWCFHSKLRE4UMVANCNFSM4K4SOVKQ.

-- Kalpathi Subramanian Ph: 704 687 8579 Associate Professor Email: krs@uncc.edu Dept of Computer Science Web:http://webpages.uncc.edu/krs The University of North Carolina Charlotte, NC 28223-0001

krs-world commented 4 years ago

This is now completed, updated the mountain paths assignment, and moved the old file based versiion to the C++ tests. Also now have a elevation_data_snippet that just tests getting the dataset - in c++ tests.

Jay, take a look. I made some changes to teh ElevationData (removed setData()/getData(), this is not needed, but provide just accessors to specific values. By the way, the rect. BB you had has negative values, so mountain paths should take care of that, by shifting the values.

krs-world commented 4 years ago

needs to update c++ scaffold

krs-world commented 4 years ago

mountain paths c++ answer and scaffold done.