search

BridgesUNCC / bridges-cxx

C++ client library for Bridges
http://bridgesuncc.github.io
2 stars 5 forks source link

Automate tests with GitHub Actions #114

Open prestoncarman opened 3 years ago

prestoncarman commented 3 years ago

Build a GitHub action to build and run the bridges tests.

esaule commented 3 years ago

Actually we do run tests everyday. You can see logs here:

http://bridgesuncc.github.io/testing-logs/index.html

Would there be an advantage to run them using github action that I am not seeing?

-- Dr Erik Saule Associate Professor at University of North Carolina at Charlotte (UNCC) tel: +1 (704) 687-8580 web: http://webpages.uncc.edu/~esaule/ == Perform academic literature search on http://theadvisor.osu.edu/

prestoncarman commented 3 years ago

I remember you saying that you had tests, but did not know where to find them. Those tests look great. I like how you can see all the different languages in one place.

A few questions:

I think one advantage of a GitHub action would be confirming a code change (via a Pull Request) has quality code prior to admitting it into the code base. It would also show the test results with submitted code with out having to run the full suite of BRIDGES tests. The test process you have currently may be fulling a different goal then testing a PR.

krs-world commented 3 years ago

Preston:

Yeah, our current tests are primarily testing the core BRIDGES code. Its not perfectly designed to test every aspect or line  of the core BRIDGES code, but at least it covers each data structure , all tutorials and all  tests for  data set extraction.  We havent set it up (yet) to be able to test any arbitrary BRIDGES program from a user, but if you think there are holes in the tests (I am sure there are many), then we can certainly add that to our test suite.

    -- kr

On 5/11/21 6:31 PM, Preston Carman wrote:

[Caution: Email from External Sender. Do not click or open links or attachments unless you know this sender.]

I remember you saying that you had tests, but did not know where to find them. Those tests look great. I like how you can see all the different languages in one place.

A few questions:

  • How would you check the tests for code change to the project?
  • How can I test my code against those tests?

I think one advantage of a GitHub action would be confirming a code change (via a Pull Request) has quality code prior to admitting it into the code base. It would also show the test results with submitted code with out having to run the full suite of BRIDGES tests. The test process you have currently may be fulling a different goal then testing a PR.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BridgesUNCC/bridges-cxx/issues/114#issuecomment-839238492, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLFEOC6WIFYUX5XFGQYWN3TNGV5LANCNFSM44XCWKVQ.

--

K.R.Subramanian Phone: (704) 687-8579 Assoc. Professor, Computer Science UNC Charlotte, Woodward 435E Email: @.*** Charlotte, NC 28223-0001 Web: www.cs.uncc.edu/~krs

If you are not the intended recipient of this transmission or a person responsible for delivering it to the intended recipient, any disclosure, copying, distribution, or other use of any of the information in this transmission is strictly prohibited. If you have received this transmission in error, please notify me immediately. Thank you.