search

BridgesUNCC / bridges-java

JAVA Client library for Bridges
http://bridgesuncc.github.io
GNU General Public License v2.0
4 stars 12 forks source link

why so static? #161

Open esaule opened 4 years ago

esaule commented 4 years ago

The Bridges class has many of its fields static. Why do we do that? It seems that may lead to surprising behaviors.

esaule commented 4 years ago

@krs-world @AlecGoncharow @quaiquai opinions?

krs-world commented 4 years ago

Is it just a matter of making all these class variables, then? It should be straightfoward to do that. I think the original motivation might have been to have only one Bridges object for an assignment? Maybe.. it was too long back..

Wouldnt multiple bridges objects let users use these different objects with the server simultaneously and cause possible communication issues?

esaule commented 4 years ago

I think it is just a matter of making these variable member of the class.

I don't think there would be codes that would stop working beside extreme use of bridges we probably don't want to support anyway.

As long as there is only a single bridges object there should not be a problem. I suppose we could have clashes in how some caching features work if we had multiple bridges objects used concurrently. But we probably already have these issues already...