BridgesUNCC / bridges-java

JAVA Client library for Bridges
http://bridgesuncc.github.io
GNU General Public License v2.0
4 stars 12 forks source link

array visualization? #88

Closed krs-world closed 6 years ago

krs-world commented 7 years ago

David, with the updates, is the array visualization also working now? Havent tested yet.

  -- krs
squeetus commented 7 years ago

Yes, the current version should work with 1d, 2d, and 3d arrays.

On Jan 14, 2017 6:17 PM, "krs-world" notifications@github.com wrote:

David, with the updates, is the array visualization also working now? Havent tested yet.

-- krs

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/krs-world/bridges/issues/88, or mute the thread https://github.com/notifications/unsubscribe-auth/ABwPkiOX9iLNEBkqjN9lwtxKcFk4rtXkks5rSVd4gaJpZM4LjxYE .

krs-world commented 7 years ago

I have the C++ array client code working, but needs testing..

One issue. Currently, the array dimensions are looked at to figure out if its dimensionality. So if give dims:[4,4,0] it doesnt work(puts up a 1D array), but dims:[4,4,1] does. This is problematic, since we can have a 3D array, with dims:[1,1,1]. I think we need to use zeros to indicate that dimension does not exist, else we need to specify the visual type to distinguish the 3 of them.

krs-world commented 7 years ago

The 3d array visualization indexing labels are in column major order. Row major is the standard. x index varies across columns, y index varies along rows.. Needs to be flipped. Java 3d. array is working, but the C++ one is not yet..