search

BridgesUNCC / bridges-python

Python client library for Bridges
http://bridgesuncc.github.io
MIT License
3 stars 4 forks source link

tuple[] type errors.. #106

Closed krs-world closed 2 years ago

krs-world commented 2 years ago

Looks like this was recently introduced.

File "/Users/kalpathi/gr/bridges/python/bridges/rectangle.py", line 121, in Rectangle def lower_left(self) -> tuple[float, float]: TypeError: 'type' object is not subscriptable

(this is on OSX)

Cant do the US cities error checking stuff on python until I can get past this error.

krs-world commented 2 years ago

Erik, did you add the tuple[] types in python yesterday? Cant do anything with python until we can get past these type errors. I dont know enough about python type hinting..

esaule commented 2 years ago

yes I did. That code did work for me. The strange thing is that we passed the tests over night...

On Wed, Aug 3, 2022 at 11:16 AM Kalpathi Subramanian < @.***> wrote:

[Caution: Email from External Sender. Do not click or open links or attachments unless you know this sender.]

Erik, did you add the tuple[] types in python yesterday? Cant do anything with python until we can get past these type errors. I dont know enough about python type hinting..

— Reply to this email directly, view it on GitHub https://github.com/BridgesUNCC/bridges-python/issues/106#issuecomment-1204087586, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIW4OSV6GJB4PCPXS6HYMTVXKEMDANCNFSM55PEX7UA . You are receiving this because you were assigned.Message ID: @.***>

-- -- Erik Saule Associate professor at University of North Carolina at Charlotte tel: +1 (704) 687 8580

krs-world commented 2 years ago

hmmm, right now I cant run any of the python tests as this error shows up. I tried even importing the Typing module, but it didnt help.

krs-world commented 2 years ago

Maybe OSX has an issue, as the tests are running on Linux,right?

krs-world commented 2 years ago

Ok, its bizarre. I went to the testing folder (web_tutorial_testing) and hand executed and it worked (shape collection example). the make run_shape_collection script from the master testing folder causes the Typing error on tuple[float, float].

I have no idea why!

krs-world commented 2 years ago

ignore the above.. I was wrong.. the tuple[] is still an issue on the Mac.