search

BridgesUNCC / bridges-python

Python client library for Bridges
http://bridgesuncc.github.io
MIT License
3 stars 4 forks source link

This will most likely raise an exception if get_time is called more than once #48

Closed AlecGoncharow closed 5 years ago

AlecGoncharow commented 5 years ago

https://github.com/BridgesUNCC/bridges-python/blob/543b161f1ce15d2602ac46950b5692b8c9e05217/bridges/data_src_dependent/earthquake_usgs.py#L6-L10

Saw this in the meeting and wanted to flag it for further inspection.

AlecGoncharow commented 5 years ago

seems to be addressed in https://github.com/BridgesUNCC/bridges-python/commit/43c2ebec75421545e02de6bde40a437be49c2a66

AlecGoncharow commented 5 years ago

Maybe rename get_time to something more private and less ambiguous? Maybe like _set_time_from_unix_timestamp?