Vertices have a separate link visualizer from edges

[acbart]

When you use get_edge to retrieve an edge, and then change properties, those are not reflected in the visualization.

Here's an abridged version of what I was trying to do:

graph = GraphAdjList()
graph.add_vertex("A")
graph.add_vertex("B")
graph.add_edge("A", "B")
graph.get_edge("A", "B").color = "red"

I checked the JSON being sent, and the new properties are not being sent at all, just seems to be defaulting to default link settings.

I believe the fault lies here:

https://github.com/BridgesUNCC/bridges-python/blob/3349d08b21c146c26d9ff83420fe0754277e5573/bridges/graph_adj_list.py#L347

Shouldn't this just be using edge._lvis instead of getting the link visualizer from the source vertex? Or rather, shouldn't Edges just have a copy of their source Element's link visualizer, rather than having their own link visualizer?

[krs-world]

Yeah, this was something we worked on recently  - Erik, is that fix reflected in our current version (the linkVisualizer issue)?

    - krs

On 3/29/20 3:17 PM, Austin Cory Bart wrote:

When you use |get_edge| to retrieve an edge, and then change properties, those are not reflected in the visualization.

Here's an abridged version of what I was trying to do:

graph= GraphAdjList() graph.add_vertex("A") graph.add_vertex("B") graph.add_edge("A","B") graph.get_edge("A","B").color= "red"

I checked the JSON being sent, and it's not being sent at all, just seems to be defaulting to default link settings.

I believe the fault lies here:

https://github.com/BridgesUNCC/bridges-python/blob/3349d08b21c146c26d9ff83420fe0754277e5573/bridges/graph_adj_list.py#L347

Shouldn't this just be using |edge._lvis| instead of getting the link visualizer from the source vertex? Or rather, shouldn't Edges just have a copy of their source Element's link visualizer, rather than having their own link visualizer?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BridgesUNCC/bridges-python/issues/67, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLFEOAYT42QTFXRN5ZP5IDRJ6ND3ANCNFSM4LWCZSCQ.

--

Kalpathi Subramanian Ph: 704 687 8579 Associate Professor Email: krs@uncc.edu Dept of Computer Science Web:http://webpages.uncc.edu/krs The University of North Carolina Charlotte, NC 28202-0001

[AlecGoncharow]

9c82f74b47399815a1cb62e94bcafc4d98c7552e should fix it