search

BridgesUNCC / bridges-python

Python client library for Bridges
http://bridgesuncc.github.io
MIT License
3 stars 4 forks source link

graph adjacency list.. #78

Open krs-world opened 3 years ago

krs-world commented 3 years ago

The get_link_visualizer() method seems incorrect. It seems to be returning the edge not the link visualizer. Its possible I might have messed when fighting with documentation, but it needs to be fixed.

AlecGoncharow commented 3 years ago

I believe this was a refactor that happened when we hoisted the link visualizer methods to the edge class so that the uses can use the edge as if it were the link visualizer. I vaguely remember modifying how the edges were pulled out of the list and I guess my editor said this code was redundant version of the get edge method.

krs-world commented 3 years ago

I fixed another issue. The C++ client was using the old link visualizer rather thanthe one in Edge (as is the case with Python and Java).

    -- krs

On 1/4/21 2:58 PM, Alec Goncharow wrote:

[Caution: Email from External Sender. Do not click or open links or attachments unless you know this sender.]

I believe this was a refactor that happened when we hoisted the link visualizer methods to the edge class so that the uses can use the edge as if it were the link visualizer. I vaguely remember modifying how the edges were pulled out of the list and I guess my editor said this code was redundant version of the get edge method.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BridgesUNCC/bridges-python/issues/78#issuecomment-754184296, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLFEOEL73XE7JO7KFFMCWDSYIMVHANCNFSM4VQW3YYA.

--

K.R.Subramanian Phone: (704) 687-8579 Assoc. Professor, Computer Science UNC Charlotte, Woodward 435E Email: krs@uncc.edu Charlotte, NC 28223-0001 Web: www.cs.uncc.edu/~krs

If you are not the intended recipient of this transmission or a person responsible for delivering it to the intended recipient, any disclosure, copying, distribution, or other use of any of the information in this transmission is strictly prohibited. If you have received this transmission in error, please notify me immediately. Thank you.