search

BridgesUNCC / bridgesAPI

Back-end Architecture for the BRIDGES Project
http://bridges-cs.herokuapp.com/
MIT License
2 stars 4 forks source link

Bridges Login.. #73

Closed krs-world closed 2 years ago

krs-world commented 2 years ago

The BRIDGES login code might have an issue. It looks like (I tested it) it wont take a user name that is the full email address of a user. It takes just the user name (without the @school.edu part). The error message is also quite misleading and reports on the size of the user ide (20 characters -- is that a restriction ? I was able to create an account with 35 chars!)

Lets fix these and be clear about the constraints on the account name and be clearer about the possible errors. Or perhaps provide those contraints before the user starts putting in their info when creating their account.

quaiquai commented 2 years ago

Is this when creating a username only? Is the user trying to create a username with the '@' symbol in the name?

krs-world commented 2 years ago

From my testing, if you create a user name that is like krs@uncc.edu and then fill out the form, it fails with an error message. If I just use the name (without the @uncc.edu) then its fine, regardless of the size of the string (I went up over 30 letters) - the error message says less than 30, which is wrong and needs to be corrected.

quaiquai commented 2 years ago

I found the location of the issue. how long would you like the limit to the username to be?

quaiquai commented 2 years ago

make size range 3-40