Bridgewater / holochrome

Use your IAM role (from instance metadata) to open the AWS console
https://chrome.google.com/webstore/detail/holochrome/fgnplojdffjfbcmoldcfdoikldnogjpa
MIT License
104 stars 9 forks source link

Wrapped script.js in an IIFE #6

Closed noahyonack closed 8 years ago

noahyonack commented 8 years ago

Wrapped script.js in an IIFE so that variables are scoped to the anonymous function as opposed to the global window object.

ryansydnor commented 8 years ago

A few issues:

  1. The manifest file only injects this script into https://console and NOT https://*.console. Please add that to the content_scripts section:
    "content_scripts": [
        {
            "matches": [
                "https://console.aws.amazon.com/*",
                "https://*.console.aws.amazon.com/*"
            ],
            "js": [
                "inject.js"
            ]
        }
    ],

(this is not your fault! found the bug while testing your change.)

  1. Bump the version number to 1.3!
ryansydnor commented 8 years ago

@noahyonack - ping!