search

Bridgewater / scala-notebook

Interactive Scala REPL in a browser
Other
741 stars 155 forks source link

ScalaMock: broken dependency #39

Open arbimo opened 10 years ago

arbimo commented 10 years ago

The ScalaMock github repository doesn't seem to exist anymore, which prevents sbt from loading the project.

kunickiaj commented 10 years ago

Fairly simple fix is to use the latest version for Scala 2.10, which is 3.1.RC1 right now. This will allow you to build and run, but the unit tests seem to be broken, so I haven't tried submitting a patch yet. ScalaMock 3.1.RC1 is the only "released" version that supports ScalaTest 2.x

The temporary fix if you just want to run the notebook as-is is to replace line 158 in build.sbt with: val scalaMock = "org.scalamock" %% "scalamock-scalatest-support" % "3.1.RC1" % "test"

alexy commented 10 years ago

Hi @paulp, was it your own fork of ScalaMock?

paulp commented 10 years ago

D'oh. When I was writing that patch scalamock had some kind of deal breaking bug against 2.10 and I forked it to work around that. I didn't mean to submit it in retaining a reference to my fork.

I haven't paid that much attention but I believe the motivating bug has since been fixed in the primary repository, so you might be able to just restore the reference.

paulp commented 10 years ago

@alexy I'll send a PR.

paulp commented 10 years ago

43

alexy commented 10 years ago

Thanks Paul! When run your new branch from SBT (project server; run) I get a blank screen in the browser...

paulp commented 10 years ago

It works for me (OSX, java8, chrome.)

alexy commented 10 years ago

Had to run compile in sbt, apparently just doing project server; run on a virginal checkout is not enough. Now see stuff! One thing is, if I run the cell, the result replaces the original expression after a second delay; is this intentional?

paulp commented 10 years ago

I'm the wrong guy to ask; I ported it to 2.10 but I am not a user of it.

alexy commented 10 years ago

Cool. The main thing it compiles and runs and all the dependencies are fresh, thanks for the updates!

alexy commented 10 years ago

Ah right, the default behavior is to hide the input: https://github.com/Bridgewater/scala-notebook/issues/23.