search

Bridgewater / scala-notebook

Interactive Scala REPL in a browser
Other
741 stars 155 forks source link

Is @n8han's fork merged? #44

Open alexy opened 10 years ago

alexy commented 10 years ago

I've tried following @n8han's sketching pamflet and did not find svg and d3 defined. Was https://github.com/n8han/scala-notebook ever merged?

badend commented 10 years ago

I have same idea, i am waiting for long time

KenCoder commented 10 years ago

Sorry. He never sent a pull request - I'm not sure if he intended for it to be working (e.g., the eventing stuff still works). I got the feeling it was more exploratory.

On Wed, Jun 25, 2014 at 1:04 AM, badend notifications@github.com wrote:

I have same idea, i am waiting for long time

— Reply to this email directly or view it on GitHub https://github.com/Bridgewater/scala-notebook/issues/44#issuecomment-47060893 .

n8han commented 10 years ago

It worked a far as I could tell, but I figured that it should be packaged as an optional module somehow.

andypetrella commented 10 years ago

Module can be a good next step? I mean, a PR will be appreciated by a plenty of us I guess. Perfect is the enemy of good ^-^