search

Bright-Computing / bic

Bright-Illumina collaboration
GNU General Public License v2.0
4 stars 5 forks source link

make the .spec & .rpm somewhat more ready for rpmlint #102

Open fgeorgatos opened 6 years ago

fgeorgatos commented 6 years ago

status on master branch as of today:

[fotis@demo2 bic]$ rpmlint *spec
Lmod-illumina.spec:39: W: non-standard-group Utilities/Shell
Lmod-illumina.spec:61: W: macro-in-comment %cmrelease
Lmod-illumina.spec:62: W: unversioned-explicit-provides environment(modules)
Lmod-illumina.spec:84: W: setup-not-quiet
Lmod-illumina.spec:121: W: macro-in-comment %{SOURCE1}
Lmod-illumina.spec:121: W: macro-in-comment %{buildroot}
Lmod-illumina.spec:121: W: macro-in-comment %{macrosdir}
Lmod-illumina.spec:121: W: macro-in-comment %{name}
Lmod-illumina.spec:165: W: macro-in-comment %{macrosdir}
Lmod-illumina.spec:165: W: macro-in-comment %{name}
Lmod-illumina.spec: W: invalid-url Source1: Lmod-files-7.0.tar.gz
0 packages and 1 specfiles checked; 0 errors, 11 warnings.

and also the .rpm:

[fotis@demo2 bic]$ ll ../rpmbuild/RPMS/noarch/Lmod-7.7.8-62_c6c833a_cm7.0_el7.noarch.rpm
-rw-rw-r-- 1 fotis fotis 5404012 Oct 18 22:55 ../rpmbuild/RPMS/noarch/Lmod-7.7.8-62_c6c833a_cm7.0_el7.noarch.rpm
[fotis@demo2 bic]$ rpmlint !$
rpmlint ../rpmbuild/RPMS/noarch/Lmod-7.7.8-62_c6c833a_cm7.0_el7.noarch.rpm
Lmod.noarch: W: non-standard-group Utilities/Shell
Lmod.noarch: E: no-changelogname-tag
Lmod.noarch: E: non-executable-script /usr/share/lmod/7.7.8/contrib/hostTypeCacheBuilder/buildSystemCache.sh 0644L /bin/bash
Lmod.noarch: E: incorrect-fsf-address /usr/share/lmod/7.7.8/contrib/tracking_module_usage/conf_create
Lmod.noarch: E: executable-marked-as-config-file /etc/site/modules/use.own.eb/append
Lmod.noarch: E: script-without-shebang /etc/site/modules/use.own.eb/append
Lmod.noarch: E: executable-marked-as-config-file /etc/site/modules/use.own.eb/prepend
Lmod.noarch: E: script-without-shebang /etc/site/modules/use.own.eb/prepend
Lmod.noarch: E: sourced-script-with-shebang /etc/profile.d/007-sh-in-it.xyzzy.py /bin/env
Lmod.noarch: E: version-control-internal-file /usr/share/lmod/7.7.8/contrib/tracking_module_usage/.gitignore
Lmod.noarch: E: non-executable-script /usr/share/lmod/7.7.8/libexec/ignore_dirs_converter 0644L /usr/bin/env
Lmod.noarch: W: dangling-symlink /etc/site/modules/settarg /usr/share/lmod/lmod/modulefiles/Core/settarg
Lmod.noarch: W: devel-file-in-non-devel-package /usr/share/lmod/7.7.8/contrib/settarg/make_example/main.c
Lmod.noarch: W: devel-file-in-non-devel-package /usr/share/lmod/7.7.8/contrib/settarg/make_example/hello.c
Lmod.noarch: W: devel-file-in-non-devel-package /usr/share/lmod/7.7.8/contrib/settarg/make_example/hello.h
Lmod.noarch: E: non-executable-script /usr/share/lmod/7.7.8/contrib/tracking_module_usage/progressBar.py 0644L /usr/bin/env
Lmod.noarch: E: incorrect-fsf-address /usr/share/lmod/7.7.8/contrib/tracking_module_usage/progressBar.py
Lmod.noarch: E: non-executable-script /usr/share/lmod/7.7.8/contrib/tracking_module_usage/BeautifulTbl.py 0644L /usr/bin/env
Lmod.noarch: E: version-control-internal-file /usr/share/lmod/7.7.8/contrib/settarg/make_example/.gitignore
Lmod.noarch: W: install-file-in-docs /usr/share/doc/Lmod-7.7.8/INSTALL
Lmod.noarch: W: empty-%post
1 packages and 0 specfiles checked; 14 errors, 7 warnings.