search

Bright-Computing / bic

Bright-Illumina collaboration
GNU General Public License v2.0
4 stars 5 forks source link

Need to investigate, --gitversion still requires some work #13

Closed fgeorgatos closed 8 years ago

fgeorgatos commented 8 years ago

Using latest illumina .spec, error w. --gitversion is still there, some fix needed:

$ ml --gitversion
/usr/bin/lua: /usr/share/lmod/lmod/libexec/lmod:597: bad argument #1 to 'write' (string expected, got nil)
stack traceback:
        [C]: in function 'write'
        /usr/share/lmod/lmod/libexec/lmod:597: in function 'main'
        /usr/share/lmod/lmod/libexec/lmod:701: in main chunk
        [C]: ?
[fgeorgatos@node004 ~]$ ml --version

Modules based on Lua: Version 6.1.7  2016-04-08 19:20
    by Robert McLay mclay@tacc.utexas.edu
fgeorgatos commented 8 years ago

this should be OK as of recent merge, TBC

fgeorgatos commented 8 years ago

Noprob any more, this is handled alright as of:

[root@bright-lmod 7.0]# ml --gitversion
git-669af9b
fgeorgatos commented 8 years ago

and more precisely, it has been fixed from this .spec file and point, onwards: https://github.com/plabrop/bic/blob/master/Lmod/branches/7.0/Lmod-illumina.spec#L16 update: https://github.com/Bright-Computing/bic/blob/master/Lmod-illumina.spec#L24