Closed fgeorgatos closed 7 years ago
btw. a more elegant way to handle this is [[ -z "$USER_IS_ROOT" ]] && return
(because it leaves the rest of the code below it stable and unindented - it's already complicated as-is.
while you are at it z00_lmod.csh
is unescaped via USER_IS_ROOT
. good moment to fix it, too
OK, this has been fixed at least as late in #69, if not earlier.
Observed side-effect:
z01-default_modules.sh.rpmnew
(undesired, watch out)eh, I need to reopen this, because -z
is not the final answer.
Sry about it, this was caused a side-effect of .rpmsave
(and as such incomplete testing).
z01-default_modules.sh
is confignoreplace
, so what you are seeing is expected behavior. If you have custom changes you dont want them to be overwritten. This file is not going to change very often, so it is expected that the admin fixes this manually.
Hi @johnnydevaprasad : the confignoreplace
is correct choice, I just meant it blinded me in detecting the issue and hence, I reported it very late in the process!
this appears to work as intended now, so closing
(see the other scripts for reference)