z01-default_modules.sh is buggy, uses -n instead of -z

Bright-Computing / bic

Bright-Illumina collaboration

GNU General Public License v2.0

4 stars 5 forks source link

z01-default_modules.sh is buggy, uses -n instead of -z #60

Closed fgeorgatos closed 7 years ago

fgeorgatos commented 7 years ago

(see the other scripts for reference)

fgeorgatos commented 7 years ago

btw. a more elegant way to handle this is [[ -z "$USER_IS_ROOT" ]] && return (because it leaves the rest of the code below it stable and unindented - it's already complicated as-is.

fgeorgatos commented 7 years ago

while you are at it z00_lmod.csh is unescaped via USER_IS_ROOT. good moment to fix it, too

fgeorgatos commented 7 years ago

OK, this has been fixed at least as late in #69, if not earlier.

Observed side-effect:

standard rpm upgrade drops change in z01-default_modules.sh.rpmnew (undesired, watch out)

fgeorgatos commented 7 years ago

eh, I need to reopen this, because -z is not the final answer. Sry about it, this was caused a side-effect of .rpmsave (and as such incomplete testing).

johnnydevaprasad commented 7 years ago

z01-default_modules.sh is confignoreplace, so what you are seeing is expected behavior. If you have custom changes you dont want them to be overwritten. This file is not going to change very often, so it is expected that the admin fixes this manually.

fgeorgatos commented 7 years ago

Hi @johnnydevaprasad : the confignoreplace is correct choice, I just meant it blinded me in detecting the issue and hence, I reported it very late in the process!

fgeorgatos commented 7 years ago

this appears to work as intended now, so closing