Bright-Computing / bic

Bright-Illumina collaboration
GNU General Public License v2.0
4 stars 5 forks source link

Lmod 7.6.x, bugfixed .spec and paraphernalia; attempt to deliver SETTARG for all #89

Closed fgeorgatos closed 7 years ago

fgeorgatos commented 7 years ago

This PR handles several outstanding issues with Lmod .spec file and resulting .rpm It should result into the final changeset before passing all initially defined validation checks.

Possible next TODOs:

ref. /home/fotis/rpmbuild/RPMS/noarch/Lmod-7.5.3-68_a7d0ac3_cm7.0_el7.noarch.rpm or later

ref. testing: https://github.com/Bright-Computing/bic/issues/6#issuecomment-309900167

fgeorgatos commented 7 years ago

hermes tests pass, but one (the infamous bash-related one):

[fotis@demo2 Lmod_test_suite]$ date
Tue Jun 20 23:07:07 CEST 2017
[fotis@demo2 Lmod_test_suite]$ git branch -av
* master                89d8f78 moving to TAG_VERSION 1.5
  remotes/origin/HEAD   -> origin/master
  remotes/origin/master 89d8f78 moving to TAG_VERSION 1.5
[fotis@demo2 Lmod_test_suite]$ time tm .
TM Version: 1.7

Starting Tests:

     Started : 23:07:11 tst: 1/5 P/F: 0:0, rt/avail/does_avail_work/t1
      passed : 23:07:12 tst: 1/5 P/F: 1:0, rt/avail/does_avail_work/t1

     Started : 23:07:12 tst: 2/5 P/F: 1:0, rt/int_subshell/does_an_int_subshell_work/t1
        diff : 23:07:12 tst: 2/5 P/F: 1:1, rt/int_subshell/does_an_int_subshell_work/t1

     Started : 23:07:12 tst: 3/5 P/F: 1:1, rt/load/does_load_work/t1
      passed : 23:07:13 tst: 3/5 P/F: 2:1, rt/load/does_load_work/t1

     Started : 23:07:13 tst: 4/5 P/F: 2:1, rt/subshell/does_a_subshell_work/t1
      passed : 23:07:14 tst: 4/5 P/F: 3:1, rt/subshell/does_a_subshell_work/t1

     Started : 23:07:14 tst: 5/5 P/F: 3:1, rt/exist/does_module_exist/t1
      passed : 23:07:14 tst: 5/5 P/F: 4:1, rt/exist/does_module_exist/t1

Finished Tests

**************************************************************************************************************************************
*** Test Results                                                                                                                   ***
**************************************************************************************************************************************

Date:             Tue Jun 20 23:07:11 2017
TARGET:
Tag:              2017_06_20
TM Version:       1.7
Hermes Version:   2.6
Lua Version:      Lua 5.1
Total Test Time:  00:00:02.86

**************************************************************************************************************************************
*** Test Summary                                                                                                                   ***
**************************************************************************************************************************************

Total:   5
diff:    1
passed:  4

*******  *  ****   *********                                     ***************
Results  R  Time   Test Name                                     version/message
*******  *  ****   *********                                     ***************
passed   R  0.437  rt/avail/does_avail_work/t1
passed   R  0.37   rt/exist/does_module_exist/t1
passed   R  0.53   rt/load/does_load_work/t1
passed   R  0.858  rt/subshell/does_a_subshell_work/t1
diff     R  0.664  rt/int_subshell/does_an_int_subshell_work/t1

*******  ****************
Results  Output Directory
*******  ****************
diff     /home/fotis/Lmod_test_suite/rt/int_subshell/t1/2017_06_20_23_07_11-Linux-x86_64-does_a_subshell_work

real    0m2.976s
user    0m1.830s
sys 0m1.184s
[fotis@demo2 Lmod_test_suite]$
fgeorgatos commented 7 years ago

lgtm, merging

fgeorgatos commented 7 years ago

ok, i've merged this since it is a prerequisite for settarg investigations and it coincides with our 2017q3 production configuration, pretty well.