search

BrightDV / BoxBox

Unofficial Android and web app for Formula 1 and Formula E fans!
https://codeberg.org/BrightDV/BoxBox
GNU General Public License v3.0
101 stars 11 forks source link

Fix subtabs white textcolor on white background #103

Closed Ultimatum22 closed 1 year ago

Ultimatum22 commented 1 year ago

I noticed the sub tabs for Sprint (shootout & results) & Race (qualifyings & results) looked empty. A better way it to solve this globally instead of per tabview, but this works for now.

Keep up the good work, I'll try to contribute some more PRs if you appreciate it.

BrightDV commented 1 year ago

Nice catch! I don't test that much the app is light mode… Anyway, thanks for the PR, and you are very welcome if you want to do more PRs :) Also, if you do some others, add some screenshots and it would be perfect!

Ultimatum22 commented 1 year ago

Screenshots of the issue before you mean? You like before and after screenshots or screenshots of the issue is fine?

No worries, I am using the app regular so I like to contribute back. I've already some minor issues. If you like me to add new features let me know.

BrightDV commented 1 year ago

I prefer one before and one after, to see what is the issue and how it is resolved. You can add new features if you think that they are useful! However, before you start working on it, open an issue with the idea, so you can explain the purpose and how you would implement it. For the bugfixes like this one, just doing a PR is fine 👍