search

BrightDV / BoxBox

Unofficial Android and web app for Formula 1 and Formula E fans!
https://codeberg.org/BrightDV/BoxBox
GNU General Public License v3.0
105 stars 10 forks source link

Stats #109

Open Ultimatum22 opened 1 year ago

Ultimatum22 commented 1 year ago

This is by far not done, but to give you a look at what I was thinking about. This is for now only points comparison but you can change which dataset is show on line 23 of chart.dart.

I did refactor a bit and re-used some of your widgets. So it's a bit bigger then I would like. You don't have to merge it yet but I like you to have a look already. If you don't like it just reject it.

Only stats of Max Verstappen works for now because driverId's is not consistent, for that reason not all driver profile work when you click on a point in the graph. I'll try to correct it later.

BrightDV commented 1 year ago

Thanks a lot for the PR! I am not able to do a proper review now, I'm sorry. I will do it as soon as possible. The website seems really complete, with a lot of data, so that's really nice.

Only stats of Max Verstappen works for now because driverId's is not consistent, for that reason not all driver profile work when you click on a point in the graph. I'll try to correct it later.

You can do a map between Ergast's driverId and the one present in the URLs (in helpers / convert_ergast_and_formula_one.dart). Thanks for your work ;)

Ultimatum22 commented 1 year ago

Thanks a lot for the PR! I am not able to do a proper review now, I'm sorry. I will do it as soon as possible. The website seems really complete, with a lot of data, so that's really nice.

No worries, yake your time

Only stats of Max Verstappen works for now because driverId's is not consistent, for that reason not all driver profile work when you click on a point in the graph. I'll try to correct it later.

You can do a map between Ergast's driverId and the one present in the URLs (in helpers / convert_ergast_and_formula_one.dart). Thanks for your work ;)

I was planning on extending it indeed, but was too lazy in the end.

BrightDV commented 1 year ago

So I just tried to run your Pr, but there are some bugs in Syncfusion's charts package. Which version of Dart/Flutter are you using, as it may fix the bug?

Ultimatum22 commented 1 year ago

Hmm it used to work a month ago but I am having trouble now as well. I was working on the latest stable back then, but not sure if a Flutter upgrade broke anything.

Update: I upgrade version (not the one that is used for this PR) and did a flutter clean ; flutter pub get and flutter run -v from terminal and got it running on my mobile

I now have the latest stable: Flutter 3.13.1 • channel stable • https://github.com/flutter/flutter.git Framework • revision e1e47221e8 (4 days ago) • 2023-08-22 21:43:18 -0700 Engine • revision b20183e040 Tools • Dart 3.1.0 • DevTools 2.25.0

BrightDV commented 1 year ago

Thanks, now it is working. So the chart looks really nice. However, I'm not sure about the data. I think that it should be more driver specific here, like points/victories/podiums of the driver at the end of the different seasons. image (https://www.f1-fansite.com/f1-drivers/max-verstappen-information-statistics/#championships) This chart could be added to the compare screen, though.

I think this would be a good start, but would need some changes: image