search

BrightGamePanel / bgpanel

Bright Game Panel
www.bgpanel.net
GNU General Public License v3.0
55 stars 50 forks source link

Update mysql.php #12

Closed dead23angel closed 10 years ago

dead23angel commented 10 years ago

Error in line 39, you have mysql_connect instead of vysql_pconnect

warhawk3407 commented 10 years ago

Maybe you mean replacing mysql_pconnect by mysql_connect ?

To be honest, I don't know which one I should use. Refering to this thread : http://stackoverflow.com/questions/2441255/php-pconnect-vs-connect it seems that is acceptable to keep pconnect.

In the future, we will drop mysql functions and we will replace it by PDO SQL.

Regards

dead23angel commented 10 years ago

I'm on php 5.4 enabled mysqli and PDO on this function error was.

warhawk3407 commented 10 years ago

The mysql_pconnect may be disabled on some hosts, that's why you have this error.

warhawk3407 commented 10 years ago

Okay, merged : https://github.com/warhawk3407/bgpanel/blob/develop-047/includes/mysql.php#L39