search

BrightShadow / CSInterface-TS

Adobe extensions CSInterface v7.0 library implementation in typescript (identical to original).
MIT License
29 stars 4 forks source link

"setContextMenuByJSON" and "setContextMenu" wrong definition #2

Closed benjamin-mueller closed 6 years ago

benjamin-mueller commented 6 years ago

Hi,

I think that both methods are wrongly defined .. shouldn't they be

setContextMenu(menu: string, callback: (clikedMenuId: string) => void): void; setContextMenuByJSON(menu: string, callback: (clikedMenuId: string) => void): void;

instead of

setContextMenu(menu: string, callback: (clikedMenuId: string) => {}): void; setContextMenuByJSON(menu: string, callback: (clikedMenuId: string) => {}): void; ?

After changing that, it worked within a angular.io driven panel ;)

Regards

Benny

BrightShadow commented 6 years ago

Hi,

What is exactly returned by the callback you are defining? Because I don't see why you could have a problem with this definition? "Strict mode"?

BrightShadow commented 6 years ago

Closing this, because of no activity.