search

BrightSpots / rcv

Ranked Choice Voting Universal Tabulator
Mozilla Public License 2.0
72 stars 19 forks source link

Ability to Edit Info in Tables #590

Closed rrojas350 closed 1 year ago

rrojas350 commented 2 years ago

Users would like the ability to edit tables in CVR files and Candidates, making it easier to edit the info if necessary. This could be achieved by adding a clickable icon to the table/row, such as a pencil, to edit the contents in the table and then save their changes by clicking the icon again.

rrojas350 commented 2 years ago

Related to #502

chughes297 commented 1 year ago

This would be extremely helpful to have if you are putting in a lot of candidate codes for cross-system tabulation and make a typo

tarheel commented 1 year ago

@HEdingfield: what do you think? I know we disabled editing in the past because of the confusing UX... but what about a pencil icon (as @rrojas350 suggested) that triggers an editing state for the row? And then, if you modify something in the row, we show Update/Cancel buttons. If there's no good way to fit this in the existing window, opening a separate modal would also be an option.

HEdingfield commented 1 year ago

Lowest effort would be to bring back what we had before, because I could probably piece it together by reversing the PRs that removed it. A modal would probably take 2 or 3 times as much effort, and would be tricky (as would the pencil thing), because we're working with a particular widget here that likely has limited APIs.

tarheel commented 1 year ago

The pencil approach seems worth investigating, since there's at least the possibility that it's not too bad. I'm inclined to agree that a modal probably isn't worth the trouble, so if the pencil is too difficult or impossible, restoring the old behavior seems OK.

ggilber1 commented 1 year ago

Glad to see you guys considering restoration of the edit function. As a former election official who created many election databases, the ability to edit an erroneous entry is always the first option looked for.

HEdingfield commented 1 year ago

Important discussion in this thread about how this design should work for the aliases field.

chughes297 commented 1 year ago

Just commenting here to flag that Gretchen Reinmeyer in Arlington requested this feature as well. Seems high priority for the next release.

May need a bit of context for this comment:

Important discussion in this thread about how this design should work for the aliases field.

I read through and not seeing how this relates? May have missed some discussion.

@HEdingfield: what do you think? I know we disabled editing in the past because of the confusing UX... but what about a pencil icon (as @rrojas350 suggested) that triggers an editing state for the row? And then, if you modify something in the row, we show Update/Cancel buttons. If there's no good way to fit this in the existing window, opening a separate modal would also be an option.

I didn't realize this was removed for UX reasons. I don't remember the UX being all that confusing?

HEdingfield commented 1 year ago

I read through and not seeing how this relates? May have missed some discussion.

It's just implementation details about how to separate multiple values for display in the table vs. the editing pop-up vs. how we store it in the backend.

I didn't realize this was removed for UX reasons. I don't remember the UX being all that confusing?

502 documents why it was confusing.