Brightify / ReactantUI

Reactant extension for UI declaration in XML
MIT License
19 stars 2 forks source link

Decide whether to crash or use UIView for elements not supported on tvOS. #59

Closed matoushybl closed 6 years ago

matoushybl commented 6 years ago

@TadeasKriz What do you think about this? Crashing would make it impossible to reuse some layouts from iOS on tvOS, however replacing views with UIView does not make sense. Making some elements unavailable on tvOS is not a solution either as neither generated code or live UI would work with reused layouts.

TadeasKriz commented 6 years ago

I'd show an error in Live and Exit with status code 1 and an error describing what was wrong.

matoushybl commented 6 years ago

It has been fixed in Live, however it does not work in generator since #if os(tvOS) doesn't work there.

matoushybl commented 6 years ago

Fixed in 0.3.0.