search

Brightspace / D2L.Security.OAuth2

Brightspace OAuth 2.0 for C#
Apache License 2.0
7 stars 16 forks source link

Migrate `kid` from Guid to string for compatibility #115

Closed khorwood closed 5 years ago

khorwood commented 5 years ago

Split the Guid -> string refactoring into it's own PR as per @omsmith

Will rebase #114 onto this once accepted.

j3parker commented 5 years ago

What's the plan for the 7.x vs. master branch stuff? @omsmith

khorwood commented 5 years ago

@j3parker Unsure.. When we're finished I should probably catch it up, but there are some behavioural changes in there to reconcile.

omsmith commented 5 years ago

I'll just reset master to 7.x and ditch my master changes for now.

khorwood commented 5 years ago

Do I need to bump this to 7.4.x?

omsmith commented 5 years ago

Nah, we'll do it post-merge and this will put it to 8.0.0 (this repo is semvery).

I assume we might want to do a few more changes before bumping though (such as the provider changes). Not that we have to wait, version numbers are free, but I don't think there's a rush to push this individual change out.

khorwood commented 5 years ago

Cool. If we're cool can we merge this, so I can put up the provider PR? Or do you want me to just stack it with the combined history?