search

Brightspace / D2L.Security.OAuth2

Brightspace OAuth 2.0 for C#
Apache License 2.0
7 stars 16 forks source link

Add a .NET 5.0 target for D2L.Security.OAuth2 #143

Closed j3parker closed 3 years ago

j3parker commented 3 years ago

Fixes #6 (for now)

Before merging we need to run the tests for .NET 5.0 too.

j3parker commented 3 years ago

It ain't pretty, but I can work on supporting the tests that are disabled in .NET 5.0 in follow-ups. The way they get disabled is obvious -- by having a .net4x.cs suffix.

j3parker commented 3 years ago

image

j3parker commented 3 years ago

Ah yeah damn, the WebAPI stuff looks busted (I just yolo'd that part today, maybe there was a reason it was left un done before)

j3parker commented 3 years ago

Yeah, the WebAPI version we're using is not compatible with .NET Core. Need to decide what to do -- maybe just not have this library in .NET 5 at all, at least to start.

j3parker commented 3 years ago

Ok -- attempt #2. Both slns build cleanly on my desktop:

$ dotnet.exe build D2L.Security.OAuth2.sln --configuration Release --framework net472
Microsoft (R) Build Engine version 16.8.0+126527ff1 for .NET
Copyright (C) Microsoft Corporation. All rights reserved.

  Determining projects to restore...
  All projects are up-to-date for restore.
  D2L.Security.OAuth2 -> C:\src\github.com\brightspace\D2L.Security.OAuth2\src\D2L.Security.OAuth2\bin\Release\net472\D2L.Security.OAuth2.dll
  D2L.Security.OAuth2.TestFramework -> C:\src\github.com\brightspace\D2L.Security.OAuth2\src\D2L.Security.OAuth2.TestFramework\bin\Release\net472\D2L.Security.OAuth2.TestFramework.dll
  D2L.Security.OAuth2.WebApi -> C:\src\github.com\brightspace\D2L.Security.OAuth2\src\D2L.Security.OAuth2.WebApi\bin\Release\net472\D2L.Security.OAuth2.WebApi.dll
  D2L.Security.OAuth2.IntegrationTests -> C:\src\github.com\brightspace\D2L.Security.OAuth2\test\D2L.Security.OAuth2.IntegrationTests\bin\Release\net472\D2L.Security.OAuth2.IntegrationTests.dll
  D2L.Security.OAuth2.UnitTests -> C:\src\github.com\brightspace\D2L.Security.OAuth2\test\D2L.Security.OAuth2.UnitTests\bin\Release\net472\D2L.Security.OAuth2.UnitTests.dll
  D2L.Security.OAuth2.WebApi.UnitTests -> C:\src\github.com\brightspace\D2L.Security.OAuth2\test\D2L.Security.OAuth2.WebApi.UnitTests\bin\Release\net472\D2L.Security.OAuth2.WebApi.UnitTests.dll
  D2L.Security.OAuth2.WebApi.IntegrationTests -> C:\src\github.com\brightspace\D2L.Security.OAuth2\test\D2L.Security.OAuth2.WebApi.IntegrationTests\bin\Release\net472\D2L.Security.OAuth2.WebApi.IntegrationTests.dll
  D2L.Security.OAuth2.Benchmarks -> C:\src\github.com\brightspace\D2L.Security.OAuth2\test\D2L.Security.OAuth2.Benchmarks\bin\Release\net472\D2L.Security.OAuth2.Benchmarks.exe

Build succeeded.
    0 Warning(s)
    0 Error(s)
$ dotnet.exe build D2L.Security.OAuth2.net50.sln --configuration Release --framework net50
Microsoft (R) Build Engine version 16.8.0+126527ff1 for .NET
Copyright (C) Microsoft Corporation. All rights reserved.

  Determining projects to restore...
  All projects are up-to-date for restore.
  D2L.Security.OAuth2 -> C:\src\github.com\brightspace\D2L.Security.OAuth2\src\D2L.Security.OAuth2\bin\Release\net50\D2L.Security.OAuth2.dll
  D2L.Security.OAuth2.TestFramework -> C:\src\github.com\brightspace\D2L.Security.OAuth2\src\D2L.Security.OAuth2.TestFramework\bin\Release\net50\D2L.Security.OAuth2.TestFramework.dll
  D2L.Security.OAuth2.UnitTests -> C:\src\github.com\brightspace\D2L.Security.OAuth2\test\D2L.Security.OAuth2.UnitTests\bin\Release\net50\D2L.Security.OAuth2.UnitTests.dll
  D2L.Security.OAuth2.IntegrationTests -> C:\src\github.com\brightspace\D2L.Security.OAuth2\test\D2L.Security.OAuth2.IntegrationTests\bin\Release\net50\D2L.Security.OAuth2.IntegrationTests.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:00.83