Dnxcore

[omsmith]

• [x] Start tracking disposables again
• [x] Dispose of ECDsa
• [x] Dispose of RSA (waiting on nuget release)
• [ ] Investigate using JsonWebKey/JsonWebKeySet from IdentityModel

[omsmith]

This is on top of #35

[j3parker]

I love this

[omsmith]

https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blob/a2f781da4d310ad1b7c7b31d8fafa0d394ec7f91/src/Microsoft.IdentityModel.Tokens/AsymmetricSignatureProvider.cs#L454

So this does disposing of things. Need to figure out how/when this happens.

[omsmith]

So JwtSecurityHandler gets it when WriteToken is called, but doesn't dispose of it or anything (Dispose is protected, so it wouldn't be able to anyway).

Seems we'll still need to track the Disposables ourselves, which in KDev is a possibility for RSASecurityKey (https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blob/KDev/src/Microsoft.IdentityModel.Tokens/RsaSecurityKey.cs#L48), but not in the latest nuget.

[omsmith]

JsonWebKey/JsonWebKeySet is a thing in IdentityModel.Tokens now, https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blob/KDev/src/Microsoft.IdentityModel.Tokens/JsonWebKeySet.cs

[omsmith]

So, as JsonWebKey/JsonWebKeySet are set up, we could use them for parsing.

JsonWebKey implements SecurityKey, and the AsymmetricSignatureProvider will do the correct thing with it, but it would have to do the correct thing multiple times, and no way for us to cache it. Sad.