search

Brightspace / D2L.Security.OAuth2

Brightspace OAuth 2.0 for C#
Apache License 2.0
7 stars 16 forks source link

Fix Permission Validation #56

Closed mtjandra closed 8 years ago

mtjandra commented 8 years ago

When validating multiple permissions, only the first permission was being validated. See added test with description Extra permission is not granted to understand what has been fixed with this change.

omsmith commented 8 years ago

On vacation, but I can look Monday. I thought it was understood this only did "singular" permissions, personally.

neverendingqs commented 8 years ago

On vacation, but I can look Monday. I thought it was understood this only did "singular" permissions, personally.

Related to if "g:r:p g2:r:p" is a "scope" or "scopes"?

mtjandra commented 8 years ago

On vacation, but I can look Monday. I thought it was understood this only did "singular" permissions, personally.

That is not how I understood it. The summary states 'Determines if granted scopes satisfy all required scopes'. Also the scope class says 'Scope strings have the following representation: {group}:{resource}:{permission[,permission]*'. So it seems that it should be able to validate the given 'scopes' (multiple permissions on some group:resource) based on the granted scopes.

omsmith commented 8 years ago

LGTM