search

Brightspace / D2L.Security.OAuth2

Brightspace OAuth 2.0 for C#
Apache License 2.0
7 stars 16 forks source link

Marking up ID2LPrincipal, IAccessToken for immutability #76

Closed toddlang closed 6 years ago

toddlang commented 6 years ago

-Updating D2L packages to latest version

It was required to update the packages because the Mutability.Audited attribute only existed in the newer versions of the CodeAnnotations. In order to ensure sensible operation, I snapped up all the D2L packages together.

toddlang commented 6 years ago

I'm a little less sure of the creation of the app.config, but I know we have a lot of unusual circumstances around our usage of System.Collections.Immutable, so I'm curious to hear others chime in on that.

toddlang commented 6 years ago

So, this commit basically gives up on trying to update the package and it's tremendously out-of-date dependencies. I've just added the minimum immutability attributes I need and I'm backing away from the effort since it's outside the scope of what I'm trying to do currently.

j3parker commented 6 years ago

Thanks!

omsmith commented 6 years ago

Appreciate that you were trying to bring everything up-to-board, but less is more :)

Thanks Todd!