search

Brightspace / d2l-license-checker

Simple tool to continuously check for D2L accepted licenses of all npm dependencies in a project.
4 stars 2 forks source link

Automated artifactory publishing is broken #46

Closed JimD2L closed 6 years ago

JimD2L commented 7 years ago

A change that went in to allow CI to run on PRs from forked repos broke the automated publish functionality.

Manual publishing is currently required.

zommerfelds commented 7 years ago

Let's fix this. I'm not sure if this is the commit that broke it https://github.com/Brightspace/license-checker-ci/commit/b6f694526e91d3db5fe65437e352a427ff666640

jkehres commented 7 years ago

Ugh. Why do we have credentials stored in git? This is something we should likely not do.

ppaskaris-d2l commented 7 years ago

The read-only credentials are in git. They are used for npm install. This is in alignment with other repos that install private packages. The build script generates publish credentials just as before.

The previous behavior was broken on forks due to a Travis CI security measure that prevents encrypted environment variables from being exposed to PRs.

Documentation

All that said, I don't know why it doesn't work on builds from master 😧

(many edits)

neverendingqs commented 7 years ago

Wild thought: maybe this change to self-reference broke it? https://github.com/Brightspace/license-checker-ci/pull/43/files

zommerfelds commented 7 years ago

@neverendingqs Wat, we depend on our own package externally? 😕 I thought we had a working system for running the license checker on itself in the unit test without having to depend on something external. Aside from it being weird I don't see a direct reason why this would make it fail though.

zommerfelds commented 7 years ago

This is the output from Travis when you push a tag:

Installing deploy dependencies
!!! Script support is experimental !!!
dpl.2
Preparing deploy
Cleaning up git repository with `git stash --all`. If you need build artifacts for deployment, set `deploy.skip_cleanup: true`. See https://docs.travis-ci.com/user/deployment/#Uploading-Files.
Saved working directory and index state WIP on (no branch): 9eec773 Merge pull request #53 from Brightspace/add-exception-chai-http
dpl.3
Deploying application
Already up-to-date!
Not currently on any branch.
nothing to commit, working tree clean
Dropped refs/stash@{0} (df62c353e93cd10d78e6dc768ef138f4f2a79409)
Script failed with status 127
failed to deploy

Hopefully https://github.com/Brightspace/license-checker-ci/pull/54 will give us more insight.

neverendingqs commented 6 years ago

Looks like https://github.com/Brightspace/license-checker-ci/pull/62 worked. I see https://d2lartifacts.artifactoryonline.com/d2lartifacts/webapp/#/artifacts/browse/tree/General/npm-local/@d2l/license-checker-ci/-/@d2l/license-checker-ci-2.1.0.tgz has been deployed by circleciuser.