search

Brightspace / d2l-license-checker

Simple tool to continuously check for D2L accepted licenses of all npm dependencies in a project.
4 stars 2 forks source link

Adding default override for pako #76

Closed lboyd closed 5 years ago

lboyd commented 5 years ago

Looking for reviewers/mergers. Maybe @hekard2l and @neverendingqs. While upgrading BDP components to node8.10 this library was discovered to require an override.

The pako repo for your review

lboyd commented 5 years ago

Poking @AntonBazhal as well - just to cast a wide net for someone who might be able to review/merge.

AntonBazhal commented 5 years ago

I'm not sure whether our legal team is OK with ZLIB license

AntonBazhal commented 5 years ago

zlib license is common to GPL, which is not in the list of accepted licenses. Though, I'm not sure whether it's not there just because nobody needed it vs it's not OK to use.

lboyd commented 5 years ago

Will decline this PR due to the ROI. Will freeze our component at an earlier serverless version to avoid the introduction of this package.

dougmoscrop commented 5 years ago

I think we should get the zlib license approved. For example Node already uses and builds on components that distribute zlib, and we distribute that, at least in the same way we would - or even, less! - as pako.

neverendingqs commented 5 years ago

It looks like we're good to go: https://d2l.slack.com/archives/C58ACLE9M/p1555599592000500?thread_ts=1555599549.000300&cid=C58ACLE9M

@lboyd - any chance you still have the branch around?

lboyd commented 5 years ago

Unlucky timing - just cleaned it up