search

Brightspace / d2l-license-checker

Simple tool to continuously check for D2L accepted licenses of all npm dependencies in a project.
4 stars 2 forks source link

Removed some D2L-ness and setup to publish to npmjs.org #84

Closed jkehres closed 4 years ago

jkehres commented 4 years ago

Major version bump. See CHANGELOG.md for complete details.

bearfriend commented 4 years ago

Was the opt-out of d2l defaults intentionally chosen over opt-in?

jkehres commented 4 years ago

Was the opt-out of d2l defaults intentionally chosen over opt-in?

Yes. I thought most consumers would be D2Lers so best to make it setup for them by default. If the --no-d2l option has little value (this tool is called d2l-license-checker so it's already predisposed to being a D2L-specific tool), then I can remove it. It's not something we at D2L need and the naming/nature of this tool may mean no one outside D2L wants to use it. In the long run, it would be nice to make this tool totally D2L independent and instead make it easy to import a D2L-specific config that is managed separately. I think the tool started out this way but then for convenience some D2L-ness got baked in.

jkehres commented 4 years ago

@AKobets what do you think about making this tool less D2L-specific? Should I revert that part of the PR and just focus on the automated publishing to npmjs.org and fixing the docs? I kind of feel like what I've done is a half hearted attempt to make this tool more general but maybe it should be an all or nothing approach - either this tool is totally D2L independent or it doesn't apologize about being blatantly D2L-specific.