search

Brightspace / polymer-siren-behaviors

utility library for shared behaviors for building siren resource based web-components
Apache License 2.0
0 stars 5 forks source link

Query Params are not grabbed properly in GET requests #42

Open svanherk opened 5 years ago

svanherk commented 5 years ago

When calling performSirenAction with a GET request, query params are not added and carried along properly. This part is completely broken: https://github.com/Brightspace/polymer-siren-behaviors/blob/master/store/siren-action-behavior.js#L22-L24

If this is fixed though, then we end up with duplicates, because some of the query params also appear as actions here: https://github.com/Brightspace/polymer-siren-behaviors/blob/master/store/siren-action-behavior.js#L32

svanherk commented 5 years ago

@jmurray-d2l @AlexBedley once this is fixed we need to remove our workarounds: https://github.com/BrightspaceHypermediaComponents/activities/blob/master/components/d2l-evaluation-hub/d2l-evaluation-hub-activities-list.js#L630 https://github.com/BrightspaceHypermediaComponents/common/blob/master/components/d2l-hm-filter/d2l-hm-filter.js#L580