search

Brightspace / polymer-siren-behaviors

utility library for shared behaviors for building siren resource based web-components
Apache License 2.0
0 stars 5 forks source link

Adding rudimentary whitelist support in lieu of globally available ge… #49

Closed pbrown-d2l closed 5 years ago

pbrown-d2l commented 5 years ago

…neric whitelist

pbrown-d2l commented 5 years ago

@omsmith - Here is the PR for what we talked about earlier

pbrown-d2l commented 5 years ago

If I run npm test locally on Master, it is also failing at the same place... any advice there would be helpful too.

ChrisKraljevicD2L commented 5 years ago

Code looks good but failing tests look not fun. Perhaps dummy URLs are being used somewhere and are now being rejected? I'll check

ChrisKraljevicD2L commented 5 years ago

Yup looks like it. Those domains can probably be changed to ones from the whitelist.