DE53088 - [CERT 20.23.05] Add extra details on error messages for fetch and extra details to telemetry logged by LX

[Kiefer-Co-D2L]

Relevant Rally Links

• https://rally1.rallydev.com/#/289692574792d/custom/355050439968?detail=%2Fdefect%2F698542249403

Description

Problem Description - Current Behaviour: The error message and telemetry logging are missing data in 2 files.

Problem Description - Expected Behaviour: We want to log details for why the status is blank in these cases.

Analysis/Investigation Details: <What analysis/investigation has been done so far to identify that this is a defect?>

• SirenAction Fetch throws an exception with missing information. ${resp.statusText} statusText is incorrect and needs to be corrected to status.
• SirenAction Fetch error also needs to include the data. The current way it is thrown will not result in the response data being included. Therefore it needs to be refactored into the message itself
• For SequencesCompletionTrackingMixin there are 2 telemetry events being logged
  • 1 needs to have the action serialized correctly
  • both need to be augmented to also include the error message

Goal/Solution

In siren-action-behavior.js:

• statusText has been replaced by status and the response text is now included in the error message
• A potential bug with handling non-JSON response bodies has been addressed

JSON error response:

Plaintext error response:

Related PRs

• Sequences: https://github.com/BrightspaceHypermediaComponents/sequences/pull/490

Remaining Work

• [x] Dev Testing

[ghost]

:tada: This PR is included in version 1.6.1 :tada:

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot :package::rocket: