search

Brightspace / rules_csharp

Bazel rules for C#
Apache License 2.0
8 stars 5 forks source link

add support for preprocessor symbols #1

Closed omsmith closed 5 years ago

omsmith commented 5 years ago

Having trouble finding where it's added, but yeah, should probably add these in AssemblyAction

Target Frameworks Symbols
.NET Framework NETFRAMEWORK, NET20, NET35, NET40, NET45, NET451, NET452, NET46, NET461, NET462, NET47, NET471, NET472, NET48
.NET Standard NETSTANDARD, NETSTANDARD1_0, NETSTANDARD1_1, NETSTANDARD1_2, NETSTANDARD1_3, NETSTANDARD1_4, NETSTANDARD1_5, NETSTANDARD1_6, NETSTANDARD2_0
.NET Core NETCOREAPP, NETCOREAPP1_0, NETCOREAPP1_1, NETCOREAPP2_0, NETCOREAPP2_1, NETCOREAPP2_2
j3parker commented 5 years ago

Cool. Ya we should have a look up table from TFM to a standard set of defines, and then automatically do them in the action based on target_framework.