Set docstrings for functions to resolve buildifier warning

Brightspace / rules_csharp

Bazel rules for C#

Apache License 2.0

8 stars 5 forks source link

Set docstrings for functions to resolve buildifier warning #127

Closed jrbeverly closed 4 years ago

jrbeverly commented 4 years ago

This PR adds docstring to the macros AssemblyAction, collect_transitive_info, csharp_repositories, resolving the last of the suppressed buildifier alerts.

Although AssemblyAction and collect_transitive_info are intended to be internal macros, buildifier is identifying them as having the possibility of external use. I suspect the issue with these two macros is similar to #124, with inconsistent visibility.

Related to #113

jrbeverly commented 4 years ago

@j3parker mentioned this to @apriyadarsheeD2L, but the check /pr/buildifier appears to be having issues reporting its status.

Exert from the build logs:

🎉 Buildifier found nothing to complain about	0s