Generalize the dotnet wrapper a bit

Brightspace / rules_csharp

Bazel rules for C#

Apache License 2.0

8 stars 5 forks source link

Generalize the dotnet wrapper a bit #131

Closed j3parker closed 4 years ago

j3parker commented 4 years ago

csharp_binary needs to become a rule which emits a cc_binary that invokes dotnet <foo>, where <foo> is the actual dll that we compile, to solve #71. Eventually <foo> will become a wrapper C# exe that tweaks assembly loading to solve #9. So all of this requires the wrapper to provide a default argv[1].

For stuff like dotnet vstest (#51) we will have argv[1] be vstest, so we also need support for baking in argv[2].

j3parker commented 4 years ago

Er, had this sitting around on a branch but I forgot to tidy some stuff up.

j3parker commented 4 years ago

Ok.

j3parker commented 4 years ago

Improvements for future PRs:

Move template params out to a header to make it obvious where they are
Remove the ifdefs in favour of Starlark select() to chose the write helper method impl
Switch to CreateProcess (the correct low-level thing) from spawnv on Windows.